Re: unified-patch18-3, still more followup

[Eric Newman <enewman@xxxxxxxxxxxx>]

This works for the offscreen mangling, but I still get the window border
artifacts, as well as artifacts in several other programs, including
Visio.

Eric

Sveinn Sveinsson wrote:
> 
> Peter Bystrom wrote:
> 
> > have you looked at the restore problems yet?
> 
> A call to XSetFunction (display, gc, GXcopy) in function
> ui_desktop_save() just before XCopyArea (display, back_pixmap, pix,
> gc, x, y, cx, cy, 0, 0); seems to fix the problem.
> 
> Regards,
> Svenni.
> 
> >
> >
> > :\
> >
> >
> >
> >
> >
> > Sveinn Sveinsson wrote:
> >
> >> Peter Bystrom wrote:
> >>
> >> >
> >> >
> >> >>  My knowledge of X is sketchy, to say the least, but I think you
> >> >>  are confusing two parameters, bits per pixel and colour depth.
> >> >>  When you run in 32bpp the colour depth is 24.  So
> >> >>  XCreatePixmap(), XCreateImage(), etc. should take DefaultDepth
> >> >>  (display, DefaultScreen (display)) as a parameter rather bpp,
> >> >>  as in the original code.  I still haven't figured out why the
> >> >>  background is not always restored correctly.
> >> >>
> >> >>  Attached is a version of xwin.c which runs in 32bpp mode (with
> >> >>  the exception of correct background restores).
> >> >>
> >> >>  Regards,
> >> >>  Svenni.
> >> >>
> >> >
> >> > a depth of 24, is consisting of a 32-bit word, RRGGBB00, right?
> >> > what is a depth of 32 consisting of then? I used that mode with
> >> > X, until I started using 2.4.0 and tdfx. a depth of 32 is also
> >> > using a 32-bit word, what is the structure here? Probably the
> >> > same as for a depth of 24, that is RRGGBB00?
> >> >     there is no such thing as 32bpp, it's a semi-mode, i.e. not
> >> > really 32bpp, but 24bpp, since the eye can't catch more colors
> >> > anyway, this is how it worked a few years ago, aint it still
> >> > true? the reason for this is the hardware, I believe.
> >> >
> >> > I'm a rockie on the x system myself, you're probably way better
> >> > than me on that ;) this is the first program I've touched using
> >> > the x system.
> >> >
> >> > is my perception of how it works flawed? :\
> >> >
> >> >
> >> > //
> >> >
> >> > peter
> >> >
> >> >
> >>
> >> I think you are right, the extra 8 bits are not used for
> >> anything.  X simply performance better in 32bpp on most modern
> >> hardware so it's preferable if you have enough memory.
> >>
> >> - Svenni.